Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading splitstore as universal blockstore not working properly in lotus-shed #12714

Open
rvagg opened this issue Nov 22, 2024 · 0 comments
Open

Comments

@rvagg
Copy link
Member

rvagg commented Nov 22, 2024

In #12703 I had to modify loadChainStore in cmd/lotus-shed/state-stats.go to make it work with my splitstore node. Prior to "fixing" it there, it would start up, load the latest tipset from the metadata store, and then fail to load the tipset from the blockstore (not found). I added that change and got it working. In the conversation in that PR, #12703 (comment), @ZenGround0 pointed out that the existing code should have worked, and in fact, this exact code path used to work in 2023. So something's sus and needs to be investigated.

  1. Investigate this issue and work out why the universal blockstore access isn't working for a splitstore node
  2. Do some unification of the loading logic in lotus-shed - this same pattern is repeated many times across the code, there's both forms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📌 Triage
Development

No branches or pull requests

1 participant