Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nv25 GST-skeleton #324

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat: add nv25 GST-skeleton #324

merged 3 commits into from
Nov 18, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Nov 11, 2024 •
edited
Loading

Ref: #321

feat: add nv25 GST-skeleton

@rjan90 rjan90 mentioned this pull request Nov 11, 2024
Merged
@rjan90
chore: create base nv25 skeleton
dc0beb3 
chore: create base nv25 skeleton
@rjan90
chore: delete migration specific for nv24
3de44f6 
chore: delete migration specific for nv24
@rjan90
fix: update package in builtin/v16/check.go to v16
306c8df 
fix: update package in `builtin/v16/check.go` to v16
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 3.14621% with 10990 lines in your changes missing coverage. Please review.

Project coverage is 3.39%. Comparing base (c12e73c) to head (306c8df).

Files with missing lines Patch % Lines
builtin/v16/market/cbor_gen.go 0.00% 1995 Missing ⚠️
builtin/v16/multisig/cbor_gen.go 0.00% 1243 Missing ⚠️
builtin/v16/power/cbor_gen.go 2.90% 1050 Missing and 20 partials ⚠️
builtin/v16/datacap/cbor_gen.go 0.00% 978 Missing ⚠️
builtin/v16/miner/invariants.go 0.00% 731 Missing ⚠️
builtin/v16/paych/cbor_gen.go 0.00% 676 Missing ⚠️
builtin/v16/eam/cbor_gen.go 0.00% 412 Missing ⚠️
builtin/v16/evm/cbor_gen.go 0.00% 403 Missing ⚠️
builtin/v16/init/cbor_gen.go 0.00% 319 Missing ⚠️
builtin/v16/check.go 0.00% 303 Missing ⚠️
... and 50 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage    3.46%    3.39%   -0.07%     
==========================================
  Files         593      660      +67     
  Lines      156783   177742   +20959     
==========================================
+ Hits         5430     6041     +611     
- Misses     149688   169852   +20164     
- Partials     1665     1849     +184
Files with missing lines Coverage Δ
builtin/v16/miner/cbor_gen.go 2.21% <ø> (ø)
builtin/v16/util/adt/store.go 100.00% <100.00%> (ø)
builtin/v16/util/math/ln.go 100.00% <100.00%> (ø)
builtin/v16/util/math/polyval.go 100.00% <100.00%> (ø)
builtin/v16/verifreg/cbor_gen.go 4.15% <ø> (ø)
builtin/v16/verifreg/invariants.go 0.00% <ø> (ø)
builtin/v16/verifreg/verified_registry_state.go 0.00% <ø> (ø)
builtin/v16/verifreg/verifreg_types.go 0.00% <ø> (ø)
actors/version.go 0.00% <0.00%> (ø)
builtin/v16/util/math/parse.go 75.00% <75.00%> (ø)
... and 58 more

@rjan90 rjan90 requested a review from masih November 18, 2024 11:32
@masih
Copy link
Member

masih commented Nov 18, 2024

How does one review 33K LOC 😱

If this is a mechanical PR, I wonder if we should consider automating it.

@rjan90
Copy link
Contributor Author

rjan90 commented Nov 18, 2024

If this is a mechanical PR, I wonder if we should consider automating it.

Yes, this is mostly a mechanical PR. It is just the steps outlined in 1. here: https://github.com/filecoin-project/lotus/blob/master/documentation/misc/Building_a_network_skeleton.md#go-state-types-checklist

@masih
Copy link
Member

masih commented Nov 18, 2024

Thanks Captured this: #326

masih
masih approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. we need a machine to generate PRs like this as it is highly error prone to have humans create the PR and humans reviewing it.

@rjan90 rjan90 merged commit 7698395 into master Nov 18, 2024
8 checks passed
@rjan90 rjan90 deleted the phi/skeleton-nv25 branch November 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masih masih masih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjan90 @codecov-commenter @masih