Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClaimAllocationsReturn not match #312

Open
yhio opened this issue Sep 10, 2024 · 2 comments
Open

ClaimAllocationsReturn not match #312

yhio opened this issue Sep 10, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@yhio
Copy link

yhio commented Sep 10, 2024

https://github.com/filecoin-project/builtin-actors/blob/54236ae89880bf4aa89b0dba6d9060c3fd2aacee/actors/verifreg/src/types.rs#L173

Causes lily parsing error: filecoin-project/lily#1316

@rjan90 rjan90 added this to FilOz Sep 10, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz Sep 10, 2024
@rvagg
Copy link
Member

rvagg commented Sep 10, 2024

ooof, probably should be SectorClaims big.Int[]

@rvagg rvagg added the good first issue Good for newcomers label Oct 4, 2024
@rvagg
Copy link
Member

rvagg commented Oct 4, 2024

I've marked this as good first issue just in case someone wants to grab it before one of us gets to it. I would encourage the implementer to do this with serialisation tests like I've been adding to the codebase slowly. See #270, 4fadeba and also in #286. They all have mirrors over in builtin-actors - same fixtures and execution, just in Rust. I use cborg on the commandline to debug the binary / hex encoded forms of these and document them as such: cborg hex2diag ... and cborg hex2json are both pretty helpful, although the json form treats bytes as an indexed map for each byte (because of Uint8Arrays) so it requires a bit of manual munging to get those comments nicely describing what the encoded forms are.

@rjan90 rjan90 moved this from 📌 Triage to 🐱 Todo in FilOz Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🐱 Todo
Development

No branches or pull requests

2 participants