Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log memory usage #39

Open
tischi opened this issue May 23, 2017 · 3 comments
Open

Log memory usage #39

tischi opened this issue May 23, 2017 · 3 comments

Comments

@tischi
Copy link

tischi commented May 23, 2017

The log window currently reports on how long each step takes, which is very nice!

However it would be also very good if the log window stated how much memory the feature stack currently needs as this might be also a limiting factor.

@ctrueden
Copy link
Member

it would be also very good if the log window stated how much memory the feature stack currently needs as this might be also a limiting factor.

Java does not provide a built-in way to ask how much memory arbitrary objects are taking. So implementing this feature might be quite involved. That said, if there are arrays of primitives involved (which there often are), it would be doable to give a lower-bound estimate. But his feasible it is depends on how deeply those array references are buried in the types involved.

@tischi
Copy link
Author

tischi commented May 24, 2017

@ctrueden:
I stage a pull request, where I tried to add logging the size of the feature stack:
#40
[EDIT]: ok, I just saw that you saw the request already.

@iarganda
Copy link
Collaborator

Thanks for your comments, @tischi and @ctrueden !
Apart from the memory taken by the feature stack array, there are related objects whose size might be worth measuring as well. I will have a look as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants