MetricName should check for name format

[pocman]

Something like that would be nice.

case class MetricName(name: String) extends AnyVal {
 assert(PrometheusMetricFormat.findFirstIn(name).isDefined, s"$name does not match required metric format ${PrometheusMetricFormat.regex}"))
}

[fiadliel]

I'll consider it; I do hate having the API throw if used incorrectly (though lost metric information could be as painful in some cases).

I assume you know that the standard way of creating MetricName values is with the metric"" string interpolator? This will validate the metric format at compile time.

[pocman]

It would be perfectly. I didn’t saw the unsafe string builder and I lost one hour trying to understand why Prometheus was returning me invalid format. I got confused because in thought it was related to the content type of my response...

…

Le 18 déc. 2017 à 13:35, Gary Coady ***@***.***> a écrit : I'll consider it; I do hate having the API throw if used incorrectly (though lost metric information could be as painful in some cases). I assume you know that the standard way of creating MetricName values is with the metric"" string interpolator? This will validate the metric format at compile time. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.