Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy code #3

Open
danreeves opened this issue Jan 8, 2015 · 1 comment
Open

Tidy code #3

danreeves opened this issue Jan 8, 2015 · 1 comment

Comments

@danreeves
Copy link
Member

Could do with tidying up and adding comments. Not a huge issue though.

@danreeves danreeves added this to the Don't be rubbish milestone Jan 8, 2015
@danreeves
Copy link
Member Author

eslint output:

src/please.js
    1:2   warning  Missing function expression name                                              func-names
    6:17  warning  Missing function expression name                                              func-names
   13:22  error    Missing space before value for key "data"                                     key-spacing
   13:38  error    Missing space before value for key "request"                                  key-spacing
   16:15  warning  Missing function expression name                                              func-names
   17:9   error    Split initialized 'var' declarations into multiple statements                 one-var
   18:13  warning  Expected indentation of 16 space characters but found 12                      indent
   19:13  warning  Expected indentation of 16 space characters but found 12                      indent
   20:13  warning  Expected indentation of 16 space characters but found 12                      indent
   21:13  warning  Expected indentation of 16 space characters but found 12                      indent
   21:38  warning  Missing function expression name                                              func-names
   22:13  warning  Expected indentation of 16 space characters but found 12                      indent
   22:34  warning  Missing function expression name                                              func-names
   23:13  warning  Expected indentation of 16 space characters but found 12                      indent
   23:42  warning  Missing function expression name                                              func-names
   24:13  warning  Expected indentation of 16 space characters but found 12                      indent
   24:40  warning  Missing function expression name                                              func-names
   25:13  warning  Expected indentation of 16 space characters but found 12                      indent
   25:32  warning  Missing function expression name                                              func-names
   25:46  error    Missing trailing comma                                                        comma-dangle
   26:9   warning  Expected indentation of 12 space characters but found 8                       indent
   27:9   warning  Expected indentation of 12 space characters but found 8                       indent
   28:9   warning  Expected indentation of 12 space characters but found 8                       indent
   29:9   warning  Expected indentation of 12 space characters but found 8                       indent
   39:13  error    All "var" declarations must be at the top of the function scope               vars-on-top
   39:25  error    Multiple spaces found before '='                                              no-multi-spaces
   43:25  warning  Missing function expression name                                              func-names
   44:26  warning  Missing function expression name                                              func-names
   45:23  warning  Missing function expression name                                              func-names
   47:55  error    Infix operators must be spaced                                                space-infix-ops
   49:53  warning  Missing function expression name                                              func-names
   69:18  error    Missing trailing comma                                                        comma-dangle
   72:13  error    All "var" declarations must be at the top of the function scope               vars-on-top
   72:48  error    "ActiveXObject" is not defined                                                no-undef
   85:42  warning  Missing function expression name                                              func-names
   95:14  error    Combine this with the previous 'var' statement with uninitialized variables   one-var
   95:14  error    All "var" declarations must be at the top of the function scope               vars-on-top
  101:32  warning  Missing function expression name                                              func-names
  101:40  warning  Missing space before function parentheses                                     space-before-function-paren
  102:34  warning  Missing function expression name                                              func-names
  102:42  warning  Missing space before function parentheses                                     space-before-function-paren
  104:25  error    Expected an assignment or function call and instead saw an expression         no-unused-expressions
  106:26  error    Closing curly brace does not appear on the same line as the subsequent block  brace-style
  111:35  warning  Missing function expression name                                              func-names
  111:43  warning  Missing space before function parentheses                                     space-before-function-paren
  117:16  error    Unexpected 'else' after 'return'                                              no-else-return
  123:5   error    ["get"] is better written in dot notation                                     dot-notation
  128:5   error    ["put"] is better written in dot notation                                     dot-notation
  133:5   error    ["patch"] is better written in dot notation                                   dot-notation
  138:5   error    ["post"] is better written in dot notation                                    dot-notation
  143:5   error    ["del"] is better written in dot notation                                     dot-notation
  143:22  error    ["delete"] is better written in dot notation                                  dot-notation
  148:41  error    ["amd"] is better written in dot notation                                     dot-notation
  148:41  error    "define" is not defined                                                       no-undef
  149:7   warning  Expected indentation of 8 space characters but found 6                        indent
  149:7   error    "define" is not defined                                                       no-undef
  149:14  warning  Missing function expression name                                              func-names
  149:22  warning  Missing space before function parentheses                                     space-before-function-paren
  150:49  error    ["exports"] is better written in dot notation                                 dot-notation
  151:7   error    ["exports"] is better written in dot notation                                 dot-notation
  151:7   warning  Expected indentation of 8 space characters but found 6                        indent
  153:7   warning  Expected indentation of 8 space characters but found 6                        indent
  153:7   error    ["please"] is better written in dot notation                                  dot-notation

✖ 63 problems (27 errors, 36 warnings)

@danreeves danreeves added the ready label Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant