Potential superfluous call to KeyCloak in RoleGuard

[krlm]

Hi,

Isn't this call

nest-keycloak-connect/src/guards/role.guard.ts

Line 107 in 5b9a642

const grant = await keycloak.grantManager.createGrant({

a superfluous if you already have a token issued for your application which potentially contains user's application and realms roles?

I'd expect that application's access token is checked for presence of requested roles, especially if TokenValidation mode i set to OFFLINE.

[ferrerojosh]

I checked just now and indeed it was an oversight on my part. It could be just a simple call to wrap in a Token class which already exists in keycloak-js: https://github.com/keycloak/keycloak-nodejs-connect/blob/cee3608b35273d9e37f70fa9b5f24d8465bb9870/middleware/auth-utils/token.js#L30-L47

When wrapped in that class, it should be the same as extracting the token class from a grant.