Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

The Package Dependency and Installer Update #193

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

thw26
Copy link
Collaborator

@thw26 thw26 commented Aug 26, 2023

This PR resolves #169. It does so by doing a few things. It creates the functions getOS1, getPackageManager (which also sets the package dependencies lists), and installPackages (a basic wrapper for our variables). Further, it modifies check_cmds and check_libs to install packages if missing.

It also simplifies the dependency checks and moves them further down the installer's process. This is the only way to keep the script from having to do this twice (i.e., once for base dependencies, once for version specific dependencies). To help with this, it also creates a new logosSetup function. Also, remember that the initial checks of the script are for a dialog program and for whether the system is running a GUI environment.

Finally, it makes the AppImage install the default/recommended method, as we know it works on all system's without having to deal with the wine staging requirement, and the AppImage install is the only option that always appears on the list as is. All this to say, it is our "stable" install.


TODO

  • The package names need to be verified for major distros
    • Debian/Ubuntu/Mint
    • Arch/Manjaro
    • Fedora
  • Add package manager yes flags
  • Add SteamOS/Steam Deck to getOS. See Steam Deck requirements #203.
  • Add option to update AppImage version. See Add Check for New AppImage Version #211. This is different from the flag which sets the AppImage version. This updates the AppImage to the latest.
  • Multiple AppImage Files. See Add Check for New AppImage Version #211.
  • Multiple Proton Directories. See Make The Wine Binary Search for Proton More Expansive #210.
  • Add a flag to controlPanel.sh to install missing dependencies for existing installations or backup installations brought to a new machine.
  • Update the README
    • Add new controlPanel flag
    • Add a general statement about the requirements, but then state that the script will attempt to automatically install needed packages. Remove distro specific instructions from README.
    • Add notice about need for other distros to be tested
  • Update the CHANGELOG
  • Update the script version

Footnotes

  1. This function is not heavily used at the moment but available just in case. Some distros will change a package name though it uses the same package manager and we may need to utilize this. Right now its only purpose is for installing libfuse3 on Debian-based systems.

@thw26 thw26 marked this pull request as draft August 26, 2023 04:31
@thw26 thw26 mentioned this pull request Oct 19, 2023
@thw26 thw26 changed the title Fix 169. The Package Dependency and Installer Update Nov 6, 2023
@thw26 thw26 force-pushed the fix-169-b branch 2 times, most recently from f181d6c to 2dec542 Compare November 7, 2023 00:43
thw26 added a commit to thw26/LogosLinuxInstaller that referenced this pull request Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant