Skip to content

Commit

Permalink
update changelog in feos-core
Browse files Browse the repository at this point in the history
  • Loading branch information
prehner committed Oct 20, 2023
1 parent 1215350 commit bd840b7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 2 additions & 0 deletions feos-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Changed `StateVec` Python getters for entropy and enthalpy to functions that accept optional `Contributions`. [#177](https://github.com/feos-org/feos/pull/177)
- `PhaseDiagram.to_dict` in Python now accepts optional `Contributions` and includes mass specific properties. [#177](https://github.com/feos-org/feos/pull/177)
- Replaced the run-time unit checks from the `quantity` crate with compile-time unit checks with custom implementations in the new `feos_core.si` module. [#181](https://github.com/feos-org/feos/pull/181)
- Renamed the keyword argument `search_option` to `identifier_option` in parameter constructors. [#196](https://github.com/feos-org/feos/pull/196)

### Removed
- Removed `EquationOfState` trait. [#158](https://github.com/feos-org/feos/pull/158)
Expand All @@ -44,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- The vapor and liquid states in a bubble or dew point iteration are assigned correctly according to the inputs, rather than based on the mole density which can be incorrect for mixtures with large differences in molar weights. [#166](https://github.com/feos-org/feos/pull/166)
- `Parameter::from_multiple_json` returns the correct parameters if a component occurs in multiple input files. [#196](https://github.com/feos-org/feos/pull/196)

### Packaging
- Updated `num-dual` dependency to 0.7. [#137](https://github.com/feos-org/feos/pull/137)
Expand Down
3 changes: 1 addition & 2 deletions feos-core/src/parameter/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,7 @@ where
// queried substances with removed duplicates
let queried: IndexSet<String> = input
.iter()
.map(|(substances, _)| substances)
.flatten()
.flat_map(|(substances, _)| substances)
.map(|substance| substance.to_string())
.collect();

Expand Down
4 changes: 2 additions & 2 deletions feos-core/tests/parameters.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ fn from_json_duplicates_input() {
assert!(matches!(
pure_records,
Err(ParameterError::IncompatibleParameters(t))
if t == "A substance was defined more than once.".to_string()
if t == "A substance was defined more than once."
));
}

Expand All @@ -124,7 +124,7 @@ fn from_multiple_json_files_duplicates() {
assert!(matches!(
my_parameters,
Err(ParameterError::IncompatibleParameters(t))
if t == "A substance was defined more than once.".to_string()
if t == "A substance was defined more than once."
));

let my_parameters = MyParameter::from_multiple_json(
Expand Down

0 comments on commit bd840b7

Please sign in to comment.