Feature/ras 1d

[sray014]

Adds functions to export the following 1D Output data from HDF files as well as unit tests for each function:

• Cross Sections
• River Reaches
• Cross Section Velocity
• Steady Flow Names
• Cross Section Area
• Encroachment Information
• Cross Section Elevation
• Cross Section WSEL Information
• Cross Section Energy Grade
• Cross Section Flow

[codecov]

Codecov Report

Attention: Patch coverage is 95.14563% with 5 lines in your changes missing coverage. Please review.

Files	Coverage Δ
src/rashdf/plan.py	99.02% <100.00%> (+0.17%)	⬆️
src/rashdf/geom.py	84.51% <91.07%> (+3.46%)	⬆️

[sray014]

@thwllms I assume the version in the pyproject.toml will need to be bumped up to 0.3.1?

[thwllms]

@thwllms I assume the version in the pyproject.toml will need to be bumped up to 0.3.1?

I'd bump to 0.4.0 since this adds new features. A +0.0.1 bump would be appropriate for a bugfixes-only update.

[slawler]

@sray014 please update the version in the project.toml

[slawler]

@thwllms Looks like the issues have been resolved, I approved, will wait for you to merge once you've had a chance to review.

[thwllms]

• The XS_STEADY_OUTPUT and XS_STEADY_ADDITIONAL constants here are redundant since they both contain the full list of variables in each corresponding enum. The other lists of specific enum values above were created because there are places where only some of the enum values are relevant. You could either combine the enums into a single XsSteadyOutputVar enum and create an XS_STEADY_OUTPUT_ADDITIONAL list that contains only "additional" vars, or simply remove the XS_STEADY_OUTPUT and XS_STEADY_ADDITIONAL vars.
• Might as well add the full list of additional output variables? Creating a named method for each is probably overkill, but having those variables in the enum would allow us to access that data via steady_profile_xs_output

[thwllms]

LGTM, just the one comment about the enums/constants in plan.py. Don't see a need to request re-review.

[sray014]

@thwllms does fiona need to be added to the pyproject dependencies for those checks to work? Not sure why it worked on the previous commit and not this one since nothing changed that deals with that.

[thwllms]

@thwllms does fiona need to be added to the pyproject dependencies for those checks to work? Not sure why it worked on the previous commit and not this one since nothing changed that deals with that.

Looks like this is happening because GeoPandas 1.0.0 was just released a few hours ago and I guess it doesn't rely on Fiona as an explicit dependency anymore. We were previously relying on version ~0.14. For now let's pin GeoPandas to version number 0.14 and create an issue to upgrade to 1.0.0.

In pyproject.toml:

name = "rashdf"
description = "Read data from HEC-RAS HDF files."
readme = "README.md"
classifiers = [
    "Development Status :: 4 - Beta",
    "Intended Audience :: Developers",
    "License :: OSI Approved :: MIT License",
    "Programming Language :: Python :: 3",
    "Programming Language :: Python :: 3.9",
    "Programming Language :: Python :: 3.10",
    "Programming Language :: Python :: 3.11",
    "Programming Language :: Python :: 3.12",
]
version = "0.4.0"
dependencies = ["h5py", "geopandas>=0.14,<0.15", "pyarrow", "xarray"]

https://pypi.org/project/geopandas/#history