Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mergeGeometries instead of mergeBufferGeometries #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtsmfm
Copy link

@mtsmfm mtsmfm commented Aug 27, 2023

Thank you for maintaining awesome library.

Since r151 mergeGeometries is preferrable.

mrdoob/three.js#25652

I checked past PR which addressed similar deprecation warn #230
I believe this library encourages users to update three.js version so I've updated package.json instead of keeping backward compatibility like the following:

import BufferGeometryUtils from 'three/examples/jsm/utils/BufferGeometryUtils.js';

const mergeGeometries =
	BufferGeometryUtils.mergeGeometries ||
	BufferGeometryUtils.mergeBufferGeometries;

Please let me know if you have a concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant