Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas elements missing from SVG #123

Closed
op3 opened this issue Apr 9, 2024 · 2 comments
Closed

Canvas elements missing from SVG #123

op3 opened this issue Apr 9, 2024 · 2 comments

Comments

@op3
Copy link

op3 commented Apr 9, 2024

I tried to create a screenshot of a page that contains several <canvas> elements. These elements are missing from the resulting SVG. The rational for this is given here.

Obviously, including the canvas elements in the SVG is only possible as a raster image. However, I still think that including the raster images is beneficial in comparison to a pure raster screenshot: You retain all the other text elements and links that are included on the site. After all, other images are embedded as well.

Otherwise, this extension is working great, so I was surprised that parts of the screenshot I created were missing. Maybe this is something worth considering? Alternatively, I would suggest to add a small note to the README to mention that canvas elements are excluded.

@felixfbecker
Copy link
Owner

Agree, happy to accept a PR! It just wasn't implemented.

@op3
Copy link
Author

op3 commented Apr 9, 2024

I just realized that this should be implemented in dom-to-svg instead. There is already a corresponding issue, and the workaround by @jkurkure works reasonably well. (Not sure if it’s useful for an actual implementation)

@op3 op3 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants