Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding adornments don't update in real time in GtTranscript #4256

Closed
botwhytho opened this issue Dec 23, 2024 · 1 comment
Closed

Expanding adornments don't update in real time in GtTranscript #4256

botwhytho opened this issue Dec 23, 2024 · 1 comment
Assignees

Comments

@botwhytho
Copy link

Visual elements show up if the transcript element is removed and added back to the scene graph (by moving to another Gt tab and back, or similar actions). The issue lies in GtTranscript>>#insertString:withAttributesForWholeString:withAttributesAtTheEnd:as the announcement sent doesn't include the expanding attributes:

(GtTranscriptInsertStringAnnouncement new 
			string: aString; 
			attributes: aCollection)

Simply adding those attributes makes this work.

(GtTranscriptInsertStringAnnouncement new 
			string: aString; 
			attributes: aCollection , aCollection2)

Before vs After:

GtTranscriptAnnouncementError.mp4
@refactoringdr
Copy link
Contributor

Thanks for the fix.

syrel pushed a commit that referenced this issue Dec 30, 2024
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.1424/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/gt4aws@8370b0 by Veit Heller
connect cloudpipeline, IAM, and organizations with cloudformation


feenkcom/gt4aws@2f5930 by Veit Heller
Add more URLs to entities


01fb7e by Don Roberts
Merge 89fce02


0744c7 by Don Roberts
Fix attributes in GtTranscript [[#4256]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants