Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repoHasTests() step is doing too much #65

Open
msrb opened this issue Aug 25, 2022 · 0 comments
Open

repoHasTests() step is doing too much #65

msrb opened this issue Aug 25, 2022 · 0 comments

Comments

@msrb
Copy link
Member

msrb commented Aug 25, 2022

What started as a relatively simple step (repoHasTests()) turned into a quite complicated thing that is trying to do way too much.
The behavior of the step is not even fully documented -- but this is on purpose, i.e. we don't want to fix the docs.

It would be better to split the functionality into 2 or 3 separate steps:

  1. clone step
  2. extract information step(s)

This way we could clone the repository and then run any number of steps that would extract all the info we need.
Currently one of the hidden (undocumented) features of the step is that it also reads ci.fmf file and checks if a specific configuration option is there (resultsdb-testcase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant