Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable partially-mapped reads filter on align command #71

Open
fedarko opened this issue Sep 24, 2024 · 0 comments
Open
Labels
backburner Low-priority things that are still good to keep track of enhancement New feature or request good first issue Good for newcomers

Comments

@fedarko
Copy link
Owner

fedarko commented Sep 24, 2024

Sometimes we may want to include "partially-mapped reads" in the alignment—for example, if the contig to which we are aligning these reads is incomplete for some reason.

The --no-rm-tmp-bam flag already serves this purpose: since the temporary BAMs (before filtering, after OSA filtering, and after OSA + PM filtering) are not deleted, the user can just use the "after OSA filtering" BAM in downstream analyses. However, it would be nice to avoid running PM filtering in the first place if it is not necessary.

So maybe we could add a flag option like --pm-filter/--no-pm-filter, or something? Where if --no-pm-filter is passed, we don't run PM filtering at all. Hmm -- I guess in this case we should use the same BAM names as usual, for the sake of clarity (so the final output BAM in this case would be sorted-osa-filtered.bam).

@fedarko fedarko added enhancement New feature or request good first issue Good for newcomers backburner Low-priority things that are still good to keep track of labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner Low-priority things that are still good to keep track of enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant