Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including (some) rare mutations from the decoy contig in the "fdr fix" BCF? #54

Open
fedarko opened this issue Sep 30, 2022 · 0 comments
Labels
backburner Low-priority things that are still good to keep track of enhancement New feature or request future ideas longer-term enhancements that'd require a lot of extra time/attention

Comments

@fedarko
Copy link
Owner

fedarko commented Sep 30, 2022

Might be nice, especially if the FDR estimates used for fixing were based on a decoy context. (For example, if the FDR estimates used were based on rare CP2 mutations in the decoy contig, then we are making the assumption that all rare CP2 mutations in the decoy contig are false -- but we have not said anything about rare non-CP2 mutations in the decoy contig.)

There are various ways we could try to "rescue" these mutations, although most of these would probably start to cause problems with the validity of the FDR estimation logic in the first place:

  • Easy option = output all rare mutations that weren't included in the context that are above a user-specified "indisputable except not really" p or r threshold. (At this point, just set that p or r threshold to the "indisputable" one in the first place, right?)

  • Harder option = construct a "fake" target contig consisting of the not-included-in-the-decoy-context positions in the decoy contig, and treat it as if it were a target contig. This sounds kind of appealing on the surface: however, I feel like this is a risky approach (e.g. the composition of the original decoy contig can influence both the "real" decoy contig we use, and this "fake" target contig we create).

Proobably not worth worrying about for now.

@fedarko fedarko added enhancement New feature or request backburner Low-priority things that are still good to keep track of future ideas longer-term enhancements that'd require a lot of extra time/attention labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner Low-priority things that are still good to keep track of enhancement New feature or request future ideas longer-term enhancements that'd require a lot of extra time/attention
Projects
None yet
Development

No branches or pull requests

1 participant