Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate arg aliases from database list #515

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

ptpaterson
Copy link
Contributor

@ptpaterson ptpaterson commented Dec 12, 2024

Ticket(s): FE-6239

Problem

Option aliases for fauna database list -h are repeated.

image

The database module applies yargsWithCommonQueryOptions and so does the list subcommand. create and delete subcommands don’t use yargsWithCommonQueryOptions

Solution

Run yargs.options() directly instead of using yargsWithCommonQueryOptions

Result

updated help
image

Testing

N/A

@ptpaterson ptpaterson requested a review from a team as a code owner December 12, 2024 17:16
@ptpaterson ptpaterson merged commit 0c7a40d into v3 Dec 12, 2024
4 checks passed
@ptpaterson ptpaterson deleted the fe-6239-list-args branch December 12, 2024 18:02
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants