Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema commands update #403

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Schema commands update #403

merged 3 commits into from
Oct 29, 2024

Conversation

echo-bravo-yahoo
Copy link
Collaborator

@echo-bravo-yahoo echo-bravo-yahoo commented Oct 21, 2024

Problem

The schema commands have been expanded and improved over the ~4 weeks since the v3 branch was forked from main.

Solution

Merge in changes from main to the v3 branch.

Result

Schema commands have similar behavior to what's in main.

Testing

Added tests for new functionality.

Copy link
Contributor

@macmv macmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

this implements changes in the flags for all schema commands as well
large changes in functionality for `schema diff` and `schema status`.
- support colors on all calls to /validate and /status
- fix schema push --active flag description
- fix schema status confirmation prompts
@echo-bravo-yahoo echo-bravo-yahoo merged commit 665db93 into v3 Oct 29, 2024
3 checks passed
@echo-bravo-yahoo echo-bravo-yahoo deleted the schema-commands-update branch October 29, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants