Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change set_port_status to be a Property #168

Open
MichaelWasher opened this issue Aug 8, 2019 · 0 comments
Open

Change set_port_status to be a Property #168

MichaelWasher opened this issue Aug 8, 2019 · 0 comments

Comments

@MichaelWasher
Copy link
Contributor

The set_port_status function in Chewie.py does not use properties to control access instead the value of port_status is public and there is also a public function intended to be used to drive the events. This can leave the state machines that are subscribe to fall out of sync with Chewie.

Change to a property and enforce a clean sub/observer pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant