Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Don't block mouse click on link after movement" not working #35

Open
SylEleuth opened this issue Mar 27, 2021 · 3 comments
Open

"Don't block mouse click on link after movement" not working #35

SylEleuth opened this issue Mar 27, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@SylEleuth
Copy link

"Don't block mouse click on link after movement" doesn't work at all. Are there any other options required to make it work?

Enabled: left button, scroll on links, scroll on text, single click, scroll on textarea, scroll on editable html, grab and drag.
Disabled when key is down.
Mouse movement detection threshold: tried 1-20

I grab on a link, move it from very top to very bottom, links open. Tested on any page that I could, but the easiest way to reproduce it is Twitter, because every tweet is a link. I can avoid links on most of the pages, but on Twitter and Tweetdeck it's impossible.

I tested it on Firefox 87.0 and Chromium 89.0.4389.90
Manjaro KDE Plasma 5.21.3
Addon version: 8.7

@SylEleuth SylEleuth added the bug Something isn't working label Mar 27, 2021
@fastaddons
Copy link
Collaborator

Hello,
Could you export your settings and upload it here (or send it to my email).
Also, when you enable "Don't block mouse click on link after movement", then the link will open if you end scrolling on the same link. So if you don't want the link to open then don't check the checkbox for "Don't block mouse click on link after movement".

@SylEleuth
Copy link
Author

Thank You for a quick reply.
Just tested it once again just to be sure and it looks like if that option is off it behaves correctly on webpages like wikipedia or google search, but not on Twitter and Tweedeck.

Settings:
{"ADDITIONAL_SPEED":0,"AXIS_LOCK":1,"CONTEXT_MENU_UNBLOCK_DELAY":100,"CURSOR":"grabbing","DISABLED_DOMAINS":{},"DISABLED_HORIZONTAL_SCROLLING_DOMAINS":{},"DISABLED_URL":{},"DISABLE_ALT":true,"DISABLE_CONTEXT_MENU_ON_MOVE":false,"DISABLE_CTRL":false,"DISABLE_SHIFT":false,"DISABLE_TYPE":0,"DURATION_MULTIPLIER":1000,"DURATION_PLUS":0,"MAXIMUM_SPEED":0,"MOMENTUM":true,"MOMENTUM_FORMULA_TYPE":0,"MOMENTUM_MAX_SPEED":0,"MOMENTUM_STOP_DETECTION":50,"MOVING_DETECTION":1,"NO_CSS_EDIT":false,"NO_LINK_BLOCK":false,"OUTSIDE_AREA_WIDTH":0,"PREVENT_BIG_JUMPS":false,"PREVENT_TEXT_SELECTION":false,"SCROLLBARS_BACKGROUND":"#f0f0f0","SCROLLBARS_COLOR":"#cdcdcd","SCROLLBARS_WIDTH":0,"SCROLL_ON_EDITABLE_HTML":true,"SCROLL_ON_LINKS":true,"SCROLL_ON_TEXT":true,"SCROLL_ON_TEXTAREA":true,"SCROLL_ON_TEXT_EDIT_WITH":0,"SCROLL_TYPE":1,"TOOLBAR_BUTTON_MAIN_SWITCH":false,"TREND_MOMENTUM_WINDOW":8,"no_prevent_default":false,"reverse":false,"scroll_button_left":true,"scroll_button_middle":false,"scroll_button_right":false,"simple_ratio_multiplier":1}

@fastaddons
Copy link
Collaborator

Thanks for the info. I can reproduce the problem on Twitter.
The problem is that those boxes on Twitter are not links (not only), they just listen to a mouse-up event and then opens the tweet. But I should be able to fix it easily.
I will look into it for the next release 8.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant