Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tooltip + button too big on Thunderbird #32

Open
sphh opened this issue Mar 3, 2021 · 10 comments
Open

Missing tooltip + button too big on Thunderbird #32

sphh opened this issue Mar 3, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@sphh
Copy link

sphh commented Mar 3, 2021

Describe the bug
Missing tooltip + button too big on Thunderbird before and after #31:
Screenshot from 2021-03-03 09-45-01

Firefox has a small button and a working tooltip (before upgrading to 8.7):
Screenshot from 2021-03-03 09-45-35

Steps To Reproduce
Steps to reproduce the behavior:

  1. Move you mouse over the toolbar in Thunderbird.

Expected behavior
I would expect for a tooltip with some contents to show.

I would also expect that the button is not larger than needed.

Device info:

  • operating system: Linux Mint 20.1
  • Browser and version: Thunderbird 78.7.1 (64-bit), [Firefox 86.0 (64-bit)]
  • addon version: 8.6 and 8.7 (Thunderbird), [8.6 (Firefox)]
@sphh sphh added the bug Something isn't working label Mar 3, 2021
@fastaddons
Copy link
Collaborator

Yeah, that's a compromise :)
Your Thunderbird is set to show "Icons beside Text" (when you right click / Customize, you can see the option in the bottom).
So it should actually show the icon with a text "ScrollAnywhere 8.7". Not exactly a short thing to have in a toolbar, especially considering you'll almost never have to use it.

So I've decided to remove the text and keep icon only - but that doesn't work so I had to keep a single space there " ". And that's the reason there is no tooltip - because if I set one, it will be shown as text next to icon.
And that's the story of how the crappy toolbar icon came to be :D.

The only good solution I see it to make a feature request for Thunderbird to allow addons to add toolbar icons without text.
I will do that later today.

@sphh
Copy link
Author

sphh commented Mar 3, 2021

Ah, I see. Thanks for explaining.

Just a stupid idea: Could you use a HAIR SPACE (, " ", U+200A) or even a ZERO WIDTH SPACE (, "​", U+200B) instead of the SPACE ( , " ", U+0020)? This does not resolve the underlying problem, but might improve the button a bit.

@fastaddons
Copy link
Collaborator

There is a zero width space??? :D, Cool! I've learned something new today! Thanks!
I'm totally gonna try that.

@sphh
Copy link
Author

sphh commented Mar 3, 2021

I only knew, that there are spaces with different width. So I was looking for the thinnest available space and came across the zero width space … Hope it works!

@fastaddons
Copy link
Collaborator

Oh man! Almost!!!
It would work but the parent node for the icon has min-width set:

toolbar[mode="full"] .toolbarbutton-1:not([hideWebExtensionLabel="true"]) {
    min-width: 55px;
}

You can see it when you inspect the toolbar with Developer Tools "Ctrl + Shift + i".

But this is helpful, all I need to do is ask them to remove it :).

@fastaddons
Copy link
Collaborator

Reported here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1696147
Let's see what they say about it.

@sphh
Copy link
Author

sphh commented Mar 3, 2021

I could the button to shrink with the following in chrome/userChrome.css:

#juraj_masiar_gmail_com_scrollanywhere-browserAction-toolbarbutton {
        /*min-width: 0 !important;*/
        min-width: unset !important;
}

Either of the two min-width line work, but the second might be might be the cleaner option (and the first line might want to have 0 px instead of 0).

@fastaddons
Copy link
Collaborator

Yeah, that's one way to fix it! :)
But still, it would be nice to have a proper fix that would work for everyone by default.

@sphh
Copy link
Author

sphh commented Jan 22, 2022

I discovered purely by accident, that you can put icons near the ‘Switch to the calendar tab’, the ‘Switch to the tasks tab’ and the ‘Switch to the CardBook tab’ (Rayquaza01/changelogger#21 (comment)). This also works for the ScrollAnywhere icon! In that place, no space is displayed beside the icon.
It's sad, that the Thunderbird developers haven't replied to your bug report…

@fastaddons
Copy link
Collaborator

Yeah, they are a very small team so I can imagine they have no time for "cosmetic" bugs.
I'm in a similar situation right now - I've build many addons and each requires some of my time and now I have so little time for each of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant