You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
first of all, thank you for this great library!
I recently had to dig into the library's code to understand why the property _lastEventIdwas not updated and why lastEventId was not appended to the url as I expected.
I think it would be nice to add some warning in the README.md file for following case :
Following code will update eventSource._lastEventId as expected:
But when method eventSource.onmessage is directly overwritten, the user has to manually update eventSource._lastEventId to reflect what previous code would do automatically:
Hi,
first of all, thank you for this great library!
I recently had to dig into the library's code to understand why the property
_lastEventId
was not updated and whylastEventId
was not appended to the url as I expected.I think it would be nice to add some warning in the README.md file for following case :
eventSource._lastEventId
as expected:eventSource.onmessage
is directly overwritten, the user has to manually updateeventSource._lastEventId
to reflect what previous code would do automatically:Thank you!
Thierry.
The text was updated successfully, but these errors were encountered: