pipenv --py might introduce newlines

[notEvil]

Just fyi: pypa/pipenv#5969
This leads to "Unable to get Python version from interpreter" and therefore broken experience

coc-pyright/src/configSettings.ts

Line 77 in 8789fcc

return child_process.spawnSync('pipenv', ['--py'], { encoding: 'utf8' }).stdout.trim();

[fannheyward]

What's your pipenv version? Tested with version 2023.10.3, no newlines.

[fannheyward]

python -c "import subprocess; print(subprocess.Popen(['pipenv', '--py'], stdout=subprocess.PIPE).stdout.read())" outputs:

b'/Users/fannheyward/src/hello-sonar/.venv/bin/python\n'

[notEvil]

As noted in "Steps to replicate": make the console small enough so the path doesn't fit on one line

[fannheyward]

But this won't affect to coc-pyright's result, doesn't it?

[notEvil]

The newline ends up in pythonPath which leads to issues later on like ENOENT (path doesn't exist) in

https://github.com/microsoft/pyright/blob/f4e309a84cbc12e91063d93dc1ede54d84d54485/packages/pyright-internal/src/common/fullAccessHost.ts#L110C22-L110C22

So the issue is affecting coc-pyright but probably needs to be fixed in Pipenv.

[fannheyward]

The newline ends up in pythonPath which leads to issues later on like ENOENT

I still can't get the point.

coc-pyright runs pipenv --py by spawning a child process, trims the output, uses the result as pythonPath. The size of the console window, no matter small or big enough, won't affect the child process result.

[notEvil]

I see, node unlike python seems to create a barrier so rich, used by Pipenv and responsible for splitting the lines, assumes a width of 80. So use a long dictionary name to reproduce with node.

[fannheyward]

use a long dictionary name to reproduce with node

What's this?

[notEvil]

I meant directory, sry!

[fannheyward]

Closing for now. Thank you for your report.

[notEvil]

Just for reference: pypa/pipenv#5971