Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash mode work properly only "one time" #697

Open
Ezra-Siton-UIX opened this issue Oct 6, 2024 · 3 comments
Open

Hash mode work properly only "one time" #697

Ezra-Siton-UIX opened this issue Oct 6, 2024 · 3 comments
Labels
needs triage This issue has not been triaged by maintainers

Comments

@Ezra-Siton-UIX
Copy link

Describe the bug

The "back" button works properly only on the first time you open the image.
https://fancyapps.com/fancybox/plugins/hash/

Demo:
https://komododecks.com/recordings/fNX1DTLMPTsDUxyljBxJ?uploadId=Ou7EBApEd8X5NF6jNqXl

Reproduction

https://komododecks.com/recordings/fNX1DTLMPTsDUxyljBxJ?uploadId=Ou7EBApEd8X5NF6jNqXl

Additional context

No response

@Ezra-Siton-UIX Ezra-Siton-UIX added the needs triage This issue has not been triaged by maintainers label Oct 6, 2024
@fancyapps
Copy link
Owner

Hi. Thanks for the reporting, but the Hash module is deprecated and will be removed in the next major version.

@Ezra-Siton-UIX
Copy link
Author

Hi. Thanks for the reporting, but the Hash module is deprecated and will be removed in the next major version.

But what about mobile? (Back button close the modal - it's very good ux).

Thanks

@fancyapps
Copy link
Owner

You see, the problem is that there is no "user presses the back button" event or concept at all. You can only try to observe some events and try to assume what the user is doing. Unfortunately, there is no solution that covers all user cases and works 100% reliably. Therefore, the Hash plugin will not be included by default in future releases and will be optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants