Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix 1.11/MAC calculation – support for hkdf-hmac-sha256.v2 #1969

Open
1 task done
kputh opened this issue Dec 6, 2024 · 1 comment · May be fixed by #1970
Open
1 task done

Matrix 1.11/MAC calculation – support for hkdf-hmac-sha256.v2 #1969

kputh opened this issue Dec 6, 2024 · 1 comment · May be fixed by #1970
Assignees
@td-famedly
Labels
feature

Comments

@kputh
Copy link

kputh commented Dec 6, 2024 •
edited
Loading

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions

Describe your problem

The specification of Matrix 1.6+ requires clients to support hkdf-hmac-sha256.v2 for MAC calculation. I examined the current (0.35.0) Matrix Dart SDK's source code – particularly key_verification.dart, line 1241 – and concluded that the SDK currently doesn't support hkdf-hmac-sha256.v2. (I apologize if I arrived at a wrong conclusion, and wasted your time.)

Describe your ideal solution

As a software developer, I want the Matrix Dart SDK to fully support Matrix 1.11 so that I don't have to fork and modify this library. (The SDK has to support hkdf-hmac-sha256.v2 and prefer it over hkdf-hmac-sha256.)

Version

0.35.0

Security requirements

None

Additional Context

No response
@kputh kputh added the feature label Dec 6, 2024
@kputh kputh changed the title Matrix 1.11/MAC calculation – support for hkdf-hmac-sha256.v2 Matrix 1.6/MAC calculation – support for hkdf-hmac-sha256.v2 Dec 6, 2024
@kputh kputh changed the title Matrix 1.6/MAC calculation – support for hkdf-hmac-sha256.v2 Matrix 1.6+/MAC calculation – support for hkdf-hmac-sha256.v2 Dec 6, 2024
@kputh kputh changed the title Matrix 1.6+/MAC calculation – support for hkdf-hmac-sha256.v2 Matrix 1.11/MAC calculation – support for hkdf-hmac-sha256.v2 Dec 6, 2024
@td-famedly
Copy link
Member

msc: matrix-org/matrix-spec-proposals#3783

@td-famedly td-famedly linked a pull request Dec 6, 2024 that will close this issue
Draft
@td-famedly td-famedly self-assigned this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@td-famedly td-famedly

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use macv2 for correct base64 encoding famedly/matrix-dart-sdk
2 participants
@kputh @td-famedly