Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/rooms/{roomId}/initialSync support #1745

Open
1 task done
henri2h opened this issue Nov 11, 2023 · 2 comments
Open
1 task done

/rooms/{roomId}/initialSync support #1745

henri2h opened this issue Nov 11, 2023 · 2 comments
Labels

Comments

@henri2h
Copy link
Contributor

henri2h commented Nov 11, 2023

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions

Describe your problem

Despite being deprecated, /rooms/{roomId}/initialSync is needed to support peeking into rooms for guest accounts.

Would you be interested in adding support for it?

Describe your ideal solution

In order to add support, one need to create

  • a new endpoint function in the MatrixApi.
  • two new models to parse the API response (InitialSyncUpdate and PaginationChunk

I created both of them in an extension

This enables adding support for room peeking.

I created a peeking extension, which could be added in matrix_dart_sdk.

The membership is set to Membership.leave to prevent storing the peeked events into the database.

Version

No response

Security requirements

No response

Additional Context

No response

@krille-chan
Copy link
Contributor

We can just add it manually to this class: https://github.com/famedly/dart_matrix_api_lite/blob/main/lib/src/matrix_api.dart should not produce any problems I think. We should consider marking it as Deprecated() in dart until the mentioned issue is clarifyied. However currently there is no priority for us to do this. Would you implement this?

@henri2h
Copy link
Contributor Author

henri2h commented Dec 8, 2023

Okay! Will do a MR when I'll have some time!

@krille-chan krille-chan transferred this issue from famedly/dart_matrix_api_lite Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants