Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad experience when refresh token expires #632

Open
wbazant opened this issue Dec 6, 2024 · 1 comment
Open

Bad experience when refresh token expires #632

wbazant opened this issue Dec 6, 2024 · 1 comment
Labels
bug Unexpected problems or unintended behavior

Comments

@wbazant
Copy link
Collaborator

wbazant commented Dec 6, 2024

The mechanism to renew a token does not always work. When it's a while since I opened the app, the refresh tries to happen (url like https://fallingfruit.org/api/0.3/user/token/refresh?api_key=AKDJGHSD ) and fails:
401 with "Invalid refresh token"

I thought it's a fallout of #617 , but as Ethan says below, likely to be a normal (although rare) case. I had this happen to me in the add location form - the call failed, and didn't get handled well: I didn't get logged out, and the submit button was stuck in 'Submitting' state, which I had no way to reset.

@wbazant wbazant added the bug Unexpected problems or unintended behavior label Dec 6, 2024
@ezwelty
Copy link
Collaborator

ezwelty commented Dec 10, 2024

@wbazant It seems normal that token refresh would fail, since eventually the refresh token expires (or is revoked server-side). Are you not then redirected to the sign in page?

@wbazant wbazant changed the title Renewing an auth token does not work Bad experience when refresh token expires Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problems or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants