Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Manifold should have different curvatures for different component manifolds. #5

Open
karish-grover opened this issue Jun 20, 2024 · 0 comments

Comments

@karish-grover
Copy link

In the productManifold class, it seems that the same curvature value is being passed for all manifolds. Consider the below piece of code from the expmap(self, u, p, c) function. The same curvature c is being passed for expmap to all sub-manifolds. This seems wrong. Shouldn't we pass the corresponding curvatures for every manifold?

        for i, manifold in enumerate(self.manifolds):
            point = self.take_submanifold_value(p, i)
            tangent = self.take_submanifold_value(u, i)
            mapped = manifold.expmap(tangent, point,c)

All the sub-manifolds cannot technically have the same curvatures since some might be positive (spherical) and some negative (hyperbolic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant