You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the productManifold class, it seems that the same curvature value is being passed for all manifolds. Consider the below piece of code from the expmap(self, u, p, c) function. The same curvature c is being passed for expmap to all sub-manifolds. This seems wrong. Shouldn't we pass the corresponding curvatures for every manifold?
for i, manifold in enumerate(self.manifolds):
point = self.take_submanifold_value(p, i)
tangent = self.take_submanifold_value(u, i)
mapped = manifold.expmap(tangent, point,c)
All the sub-manifolds cannot technically have the same curvatures since some might be positive (spherical) and some negative (hyperbolic).
The text was updated successfully, but these errors were encountered:
In the
productManifold
class, it seems that the same curvature value is being passed for all manifolds. Consider the below piece of code from theexpmap(self, u, p, c)
function. The same curvaturec
is being passed forexpmap
to all sub-manifolds. This seems wrong. Shouldn't we pass the corresponding curvatures for every manifold?All the sub-manifolds cannot technically have the same curvatures since some might be positive (spherical) and some negative (hyperbolic).
The text was updated successfully, but these errors were encountered: