Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event.az and event.simulation_truth.air_shower.phi use different coordinate systems #71

Open
maxnoe opened this issue Feb 15, 2018 · 3 comments

Comments

@maxnoe
Copy link
Member

maxnoe commented Feb 15, 2018

One is Corsika (0° at megnetic north), one is Ceres (0° at geographic south)

@relleums
Copy link
Member

Indeed. I have code which solves this: https://github.com/relleums/phs_air_shower_feature_generation
But where should it go? Any ideas? I discussed this also lately with Kai.

@maxnoe
Copy link
Member Author

maxnoe commented Feb 15, 2018

I think we should just fix it. Use the astropy's and FACT-Tools coordinate system definition.

You can directly do this by not using MSimPointingPos or the data from the corsika file but use source_position_{az,zd} and pointing_position_{az,zd} with the current FACT-Tools version.

I think we should do this after we released FACT-Tools 1.0. We plan a complete reprocessing of all data with FACT-Tools 1.0

@maxnoe
Copy link
Member Author

maxnoe commented Feb 28, 2018

What's even worse is that event.az is in a different coordinate system for observations and simulations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants