Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make openssl install less confusing, align openssl version #152

Closed
wants to merge 1 commit into from

Commits on Dec 2, 2024

  1. make openssl install less confusing, align openssl version

    Summary:
    X-link: facebookincubator/zstrong#1073
    
    On linux getdeps uses system openssl,  on macOS we mostly use the homebrew one on github CI. Both of these are openssl3.x,  however the fallback build from source version is still set as openssl1.1.  This can be confusing, giving the impression getdeps based builds need openssl1.1
    * Update the openssl manifest source url to openssl-3.0.15,  this version picked to match the ubuntu 22.04 LTS system packages.
    
    The other potentially confusing part was that the openssl source tarball was downloaded even when on on a platform like Linux where openssl is always taken from the system packages.
    * Make the download configurable so that does nothing if satisified from system packages.
    
    Reviewed By: ckwalsh
    
    Differential Revision: D66495352
    ahornby authored and facebook-github-bot committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    da29418 View commit details
    Browse the repository at this point in the history