Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Meta Issue: Fix developer instructions #108

Open
hermanventer opened this issue Apr 1, 2019 · 3 comments
Open

Meta Issue: Fix developer instructions #108

hermanventer opened this issue Apr 1, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@hermanventer
Copy link
Contributor

hermanventer commented Apr 1, 2019

Issue

If you like compilers and related tools, you are a meta-programmer, so you should like meta issues as well. This issue is a task to create tasks.

Since you are new here, please keep track of all of the surprises you've encountered and the things you had to find out the hard way. Then make an issue to get the fixed.

Ideally, follow that up with PR in which you fix it. Many thanks for doing that!

Steps to Reproduce

Read the developer documentation and try to fix an issue.

Expected Behavior

You got going with no problems and everything is crystal clear.

Actual Results

You muttered WTF on several occasions.

@hermanventer hermanventer added the good first issue Good for newcomers label Apr 3, 2019
@johnperry-math
Copy link

I wouldn't mind helping with this, as I'm in that situation right now: cargo mirai never warns me about anything.

For example:

use argh::FromArgs;

#[derive(FromArgs)]
/// some args
struct Args {
    /// a value
    #[argh(positional)]
    a: usize,
}

pub fn main() {
    let args: Args = argh::from_env();
    let mut v: Vec<usize> = vec!();
    v.push(0);
    println!("{}", v[args.a]);
}

It ought to object strenuously to v[args.a], but I get nothing!

Following the instructions, I did:

git clone https://github.com/facebookexperimental/MIRAI.git
cd MIRAI
cargo install --locked --path ./checker
cd /path/to/crate
cargo mirai

So, what am I doing wrong? I wouldn't mind updating the instructions with an explanation of how to run it, including a sample program that is guaranteed to produce warnings on first run.

@hermanventer
Copy link
Contributor Author

hermanventer commented Mar 16, 2023

Ideally we need a new issue for each such problem. I.e. the is a meta issue and we need a concrete issue. :-)

@johnperry-math
Copy link

Whoops! I didn't realize that was the case. Thank you for opening an issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants