-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React 19] useEffect does not re-fire on hot reload with React 19 and vite #29915
Comments
Hey @gkiely - |
I've looked into it and this happen only with StrictMode enabled. |
Does this work in React 18? |
Yep, React with 18 useEffect runs everytime if the file is updated |
Can reproduce with the provided repro and also |
Gentle bump on this @eps1lon. Unfortunately it is a blocker for me upgrading to 19. |
In prior versions of react, saving a file will trigger the components useEffect hooks to run. This does not work for react 19.
This applies to both @vitejs/plugin-react-swc and @vitejs/plugin-react
Repo: https://github.com/gkiely/swc-issue
Steps to reproduce:
Video reproduction:
https://www.loom.com/share/b493602e3f7244d2948c5bb871531881?sid=c9bdec15-5b87-4375-a659-6c63804cb032
Notes:
I previously opened a ticket here but it is perhaps an issue with react 19: vitejs/vite-plugin-react#335
The text was updated successfully, but these errors were encountered: