[lexical-playground][image-node] Bug Fix: Load image error UI #6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
MaxPlav
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
StyleT
added
the
contribution-week
StyleT
reviewed
May 15, 2024
There was a problem hiding this comment.
May I suggest using SVG instead of PNG? You can take this one (MIT license) for example: https://www.svgrepo.com/svg/377374/image-broken
There was a problem hiding this comment.
thanks, replaced the fallback image with that
MaxPlav
force-pushed
the
fix/image-load-error-5564
branch
from
eaf553e to
cf175ec
Compare
StyleT
approved these changes
May 15, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if an image fails to load because of a network error, the page is down, etc. the Node is silently inserted but no UI is shown.
Description
Adding a fallback image that would substitute an original image if it fails to load due to a network failure etc.
Closes: #5564
Test plan
#5564 (comment)
Before
image-before.mov
After
image_after.mov
Insert relevant screenshots/recordings/automated-tests