You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are other reasons not to use default exports (e.g. the types are wrong in cjs, the module names are not always consistent with what we call them in OSS docs for www reasons, etc.) but I think inconsistency is a good enough reason.
I propose that we, at minimum:
Add named exports in all of these cases
Bonus points if we can agree to:
Mark default exports as @deprecated
Add a lint rule to warn when new default exports are added to public entrypoints (at least for packages/lexical-react/ where it has happened several times and has the most impact, everything else is a barrel file or not really API code like lexical-eslint)
The text was updated successfully, but these errors were encountered:
The following modules use default exports in their entrypoints, which is inconsistent with the rest of the monorepo:
There are other reasons not to use default exports (e.g. the types are wrong in cjs, the module names are not always consistent with what we call them in OSS docs for www reasons, etc.) but I think inconsistency is a good enough reason.
I propose that we, at minimum:
Bonus points if we can agree to:
@deprecated
The text was updated successfully, but these errors were encountered: