New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slip: ineffective optimisation #66

Open

lie-yan opened this issue Dec 4, 2024 · 0 comments

lie-yan commented Dec 4, 2024

lexical-ios/Lexical/Core/Reconciler.swift

Lines 470 to 471 in db0a821

    
           let nextHasPrevKey = nextChildren.contains(prevKey) 
        
           let prevHasNextKey = prevChildren.contains(nextKey)

According to comment // the sets exist as an optimisation for performance reasons, it should be

let nextHasPrevKey = nextChildrenSet!.contains(prevKey) 
let prevHasNextKey = prevChildrenSet!.contains(nextKey)

The text was updated successfully, but these errors were encountered:

lie-yan mentioned this issue

Fixed removal handlers for error listeners #64

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment