Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassicTheme ColorModeToggle shows both icons in Firefox #9582

Closed
6 of 7 tasks
mattcorner opened this issue Nov 24, 2023 · 1 comment
Closed
6 of 7 tasks

ClassicTheme ColorModeToggle shows both icons in Firefox #9582

mattcorner opened this issue Nov 24, 2023 · 1 comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: duplicate This issue or pull request already exists in another issue or pull request

Comments

@mattcorner
Copy link

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

When a Docusaurus 3 site using the classic theme is built, in Firefox, the toggle colour mode button shows both icons rather than the single icon for the current mode.

This works fine in other browsers, and works fine in Firefox when using npm run start.

The issue on occurs when running npm run build && npm run serve

Reproducible demo

https://codesandbox.io/p/sandbox/divine-sky-wcnrpr

Steps to reproduce

  1. npx create-docusaurus@latest doc classic --typescript
  2. npm run build && npm run serve

Expected behavior

Expect the button to be either:

image
image

Actual behavior

Actually seeing this:

image
image

Your environment

  • Public source code: N/A
  • Public site URL: N/A
  • Docusaurus version used: 3.0.0
  • Environment name and version (e.g. Chrome 89, Node.js 16.4): Firefox 120.0 (64-bit)
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS): Seen on MacOS and Windows

Self-service

  • I'd be willing to fix this bug myself.
@mattcorner mattcorner added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Nov 24, 2023
@Josh-Cena
Copy link
Collaborator

Duplicate of #9493

@Josh-Cena Josh-Cena marked this as a duplicate of #9493 Nov 24, 2023
@Josh-Cena Josh-Cena closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2023
@Josh-Cena Josh-Cena added closed: duplicate This issue or pull request already exists in another issue or pull request and removed status: needs triage This issue has not been triaged by maintainers labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: duplicate This issue or pull request already exists in another issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants