From 61e3fb09fdc3f313eb5944323a4d2706ce96c377 Mon Sep 17 00:00:00 2001
From: Jorens Merenjanu <jorensmerenjanu@gmail.com>
Date: Fri, 6 Oct 2023 14:55:49 +0000
Subject: [PATCH] feat(errors): throw error instead of just logging it when
 checking plugin versions

additionally remove import for logger because it is not needed.
---
 packages/docusaurus/src/server/siteMetadata.ts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/docusaurus/src/server/siteMetadata.ts b/packages/docusaurus/src/server/siteMetadata.ts
index affcbf7183ec..faedab4fcfdb 100644
--- a/packages/docusaurus/src/server/siteMetadata.ts
+++ b/packages/docusaurus/src/server/siteMetadata.ts
@@ -7,7 +7,6 @@
 
 import fs from 'fs-extra';
 import path from 'path';
-import logger from '@docusaurus/logger';
 import {DOCUSAURUS_VERSION} from '@docusaurus/utils';
 import type {
   LoadedPlugin,
@@ -82,10 +81,9 @@ function checkDocusaurusPackagesVersion(siteMetadata: SiteMetadata) {
         versionInfo.version &&
         versionInfo.version !== docusaurusVersion
       ) {
-        // Should we throw instead? It still could work with different versions
-        logger.error`Invalid name=${plugin} version number=${versionInfo.version}.
+        throw new Error(`Invalid name=${plugin} version number=${versionInfo.version}.
 All official @docusaurus/* packages should have the exact same version as @docusaurus/core (number=${docusaurusVersion}).
-Maybe you want to check, or regenerate your yarn.lock or package-lock.json file?`;
+Maybe you want to check, or regenerate your yarn.lock or package-lock.json file?`);
       }
     },
   );