Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dangling ; in installing vpdq #1691

Open
ZeyadTarekk opened this issue Nov 8, 2024 · 3 comments
Open

Fix the dangling ; in installing vpdq #1691

ZeyadTarekk opened this issue Nov 8, 2024 · 3 comments
Labels
mlh Related to Major League Hacking Fellowship

Comments

@ZeyadTarekk
Copy link

https://github.com/facebook/ThreatExchange/blame/65c92ce52af208cf9cd1557df9d15937bd4c4ea7/vpdq/cpp/vpdq/cpp/hashing/ffmpegwrapper.cpp#L134

 INFO:setup.py:Compiling vpdqlib and pdqlib...
      CRITICAL:setup.py:/tmp/pip-install-mkatbfmh/vpdq_af861797f092467ca1b78712c95701e6/cpp/vpdq/cpp/hashing/ffmpegwrapper.cpp:130:62: error: extra ‘;’ [-Werror=pedantic]
        130 |     : m_frame(std::move(frame)), m_frameNumber(frameNumber){};
            |                                                              ^
      /tmp/pip-install-mkatbfmh/vpdq_af861797f092467ca1b78712c95701e6/cpp/vpdq/cpp/hashing/ffmpegwrapper.cpp:134:2: error: extra ‘;’ [-Werror=pedantic]
        134 | };
            |  ^
      cc1plus: all warnings being treated as errors
      gmake[2]: *** [vpdq/CMakeFiles/vpdqlib.dir/build.make:121: vpdq/CMakeFiles/vpdqlib.dir/cpp/hashing/ffmpegwrapper.cpp.o] Error 1
      gmake[1]: *** [CMakeFiles/Makefile2:186: vpdq/CMakeFiles/vpdqlib.dir/all] Error 2
      gmake: *** [Makefile:103: all] Error 2
      
      CRITICAL:setup.py:Failed to compile vpdq library.
@ZeyadTarekk
Copy link
Author

@ianwal Could you check that

@ianwal
Copy link
Contributor

ianwal commented Nov 8, 2024

Yep it's a typo. Semicolon should be removed. I'll fix this weekend or anyone else can. Feel free to make a PR for it.

Out of curiosity, are you able to see what compiler and compiler version that is detecting this? The CI doesn't pick this up, which uses a somewhat old GCC version, whatever is the default on its Ubuntu version.

@ZeyadTarekk
Copy link
Author

@ianwal
gcc version 10.2.1 20210110 (Debian 10.2.1-6)

I have create a PR to solve it

@Dcallies Dcallies added the mlh Related to Major League Hacking Fellowship label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlh Related to Major League Hacking Fellowship
Projects
None yet
Development

No branches or pull requests

3 participants