You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a large, multistep issue. In general, it seems to replace the custom file-and-pickle based solution for storage in the python-threatexchange CLI with a more standardised solution using pythons dbm module.
This requires backwards-compatibility with the current version, with the intent to deprecate the old storage in a future 2.0.0 release.
We can do each bit piecemeal, but it will require a lot of refactoring:
Create a second implementation of the interface that instead uses dbm as the storage backing - you can test with a fresh copy of the CLI to make sure it works - add tests (own PR)
Add compatibility logic - first check the local state to see if there is an existing state, and if not, use your new DBM code, and if so, use the historic code
Here are the sub-issues for each interface:
The text was updated successfully, but these errors were encountered:
Dcallies
changed the title
[py-tx][mlh] Upgrade py-tx CLI storage implementation to dbm
[py-tx][mlh][tracking issue] Upgrade py-tx CLI storage implementation to dbm
Nov 8, 2024
This is a large, multistep issue. In general, it seems to replace the custom file-and-pickle based solution for storage in the python-threatexchange CLI with a more standardised solution using pythons dbm module.
This requires backwards-compatibility with the current version, with the intent to deprecate the old storage in a future 2.0.0 release.
We can do each bit piecemeal, but it will require a lot of refactoring:
Foreach of the major interface types in https://github.com/facebook/ThreatExchange/blob/main/hasher-matcher-actioner/src/OpenMediaMatch/storage/interface.py:
Here are the sub-issues for each interface:
The text was updated successfully, but these errors were encountered: