Fly to nearby MapRoulette challenge #1618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MapRouletteService
tannerwuster
force-pushed
the
fly_to_nearby_challenge
branch
from
b97a0d6
to
2c5586d
Compare
bhousel
reviewed
Nov 21, 2024
There was a problem hiding this comment.
There are some things I would do differently about this:
- I am not a fan of using a checkbox in the Map Data pane. This list is mostly for data that the user can toggle on-off, not really for random settings related to that layer. I would expect a setting like this to be a checkbox down near the action buttons (I fixed it, can't complete)
- Why does
filterNearbyTasksthen do a secondary fetch to get the challenge details? I would expect that the user means to work on a nearby task on the same challenge - and that we have all the nearby tasks fetched already - we wouldn't make anew QAItemhere? - I'd avoid introducing d3/UI code into the
MapRouletteServicefile. I see stuff to set the header title, and that should all just happen automatically once you docontext.enter('select', {selection})
I guess I'll comment some more in the files
bhousel
reviewed
Nov 21, 2024
| selection.set(task.id, task); | ||
| context.enter('select', { selection }); | ||
|
|
||
| d3_select('.sidebar-header').text(task.title); // ensure the title is set |
There was a problem hiding this comment.
Something is off if entering 'select' mode with the task doesn't set the sidebar up properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation to Nearby Tasks:
Screen.Recording.2024-11-20.at.14.56.47.mov
closes #1613