Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider making Slot a button #21

Open
oliverjam opened this issue Sep 28, 2018 · 0 comments
Open

Please consider making Slot a button #21

oliverjam opened this issue Sep 28, 2018 · 0 comments

Comments

@oliverjam
Copy link

You've put a click-handler on a div, which is a big accessibility no-no. Using a button would require a bit more style-resetting but would give you free keyboard support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverjam