You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
page header links have some issues (some were changing the order the scss was loaded in the webpack bundle)
application name
+ missing hover state
+ missing focus state
language dropdown
+ not even focusable. this is a problem addressed by #176
login / out
+ missing focus state
+ no labels of any kind (text or aria), nor any identifying mark as to what it should do
general
+ when you actually hover things, the text color is the element but the background color is it's parent - the <li> - which also has a hover state. this doesnt seem like a good pattern to follow
i will fix these, and use the fixes in lumberjack. should i keep these fixes in lumberjack's fork, or should it be applied to this one as well? (and in the latter case, what colors etc should i use?)
The text was updated successfully, but these errors were encountered:
The last screenshot is probably only on your application. In my applications when I hover a menu item it's background color fade to a darker one and the foreground stays the same.
page header links have some issues (some were changing the order the scss was loaded in the webpack bundle)
application name
+ missing hover state
+ missing focus state
language dropdown
+ not even focusable. this is a problem addressed by #176
login / out
+ missing focus state
+ no labels of any kind (text or aria), nor any identifying mark as to what it should do
general
+ when you actually hover things, the text color is the element but the background color is it's parent - the
<li>
- which also has a hover state. this doesnt seem like a good pattern to followi will fix these, and use the fixes in lumberjack. should i keep these fixes in lumberjack's fork, or should it be applied to this one as well? (and in the latter case, what colors etc should i use?)
The text was updated successfully, but these errors were encountered: