Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(header) inconsistent and absent focus and hover states #181

Open
mousemke opened this issue Jun 21, 2018 · 1 comment
Open

bug(header) inconsistent and absent focus and hover states #181

mousemke opened this issue Jun 21, 2018 · 1 comment
Assignees

Comments

@mousemke
Copy link
Contributor

mousemke commented Jun 21, 2018

page header links have some issues (some were changing the order the scss was loaded in the webpack bundle)

application name
+ missing hover state
+ missing focus state

language dropdown
+ not even focusable. this is a problem addressed by #176

login / out
+ missing focus state
+ no labels of any kind (text or aria), nor any identifying mark as to what it should do

general
+ when you actually hover things, the text color is the element but the background color is it's parent - the <li> - which also has a hover state. this doesnt seem like a good pattern to follow

screen shot 2018-06-21 at 13 55 48

i will fix these, and use the fixes in lumberjack. should i keep these fixes in lumberjack's fork, or should it be applied to this one as well? (and in the latter case, what colors etc should i use?)

@fokusferit fokusferit self-assigned this Jun 22, 2018
@fragsalat
Copy link
Contributor

The last screenshot is probably only on your application. In my applications when I hover a menu item it's background color fade to a darker one and the foreground stays the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants