Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGFIP scope : required value field ? #9

Open
giffarda opened this issue Nov 7, 2022 · 2 comments
Open

DGFIP scope : required value field ? #9

giffarda opened this issue Nov 7, 2022 · 2 comments

Comments

@giffarda
Copy link

giffarda commented Nov 7, 2022

It seems there are few mistakes in the DGFIP schema.json.
On dgfip_identity_field and dgfip_tax_notice_field types, a field "value" is indicated as "required" whereas there is no value property for these types.

@giffarda
Copy link
Author

giffarda commented Nov 7, 2022

Moreover, the attributes table no mentions the taxNotices array. The table must be indicate :

Name Type
declarant1 DGFIP identity
declarant2 DGFIP identity
taxNotices DGFIP tax notice[ ]

@BertrandGervais
Copy link
Collaborator

Thanks. I have create PR #11 to fix these issues. Since it does not change the data model, I think it could be merged. @ghislainfabmob, what do you think of merging this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants