This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
separating workers #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Sep 25, 2018
| let myInfo = payload :?> MyPushNotificationInfo | ||
|
|
||
| let title = "My title" | ||
| let options:NotificationOptions = |
There was a problem hiding this comment.
How should this be tackled? What should NotificationOptions be in this case? Just a plain record?
There was a problem hiding this comment.
When facing this kind of situation I like to provide an helper on top of it.
Something like:
Notification.empty
|> Notification.body "my body"
|> Notification.icon "my-icon"
....
Like that the user only specify what is needed for him. This is the same approach I used in Thoth.Elmish.Toast for example.
MangelMaxime
suggested changes
Oct 4, 2018
|
Might re-do this in the future sometime, no intentions to finish this in its current form. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #67.
Not sure if I made things better.
The
test.fsxrepresents code I have in my current service worker.It is an improvement because of the latest ts2fable generation of lib.webworker.d.ts.
However I believe some manually work to Fable.Import.WebWorkers will still be required.