Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Making CoordinateSystem mandatory if Pos3D is present #163

Open
Edouard2laire opened this issue Dec 9, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@Edouard2laire
Copy link
Contributor

Edouard2laire commented Dec 9, 2024

Hello,

Is your suggestion related to a problem? Please describe.
The main objective of having access to Pos3D (sourcePos3D, detectorPos3D) is to be able to coregister the montage with a template or the subject anatomy. This can however become tricky without information about the coordinate system used.

Additionally, the co-registration can be made much easier with access to landmark position (nasion, left/right ear...)

Describe the solution you'd like

Have the coordinate system be mandatory if sourcePos3D and detectorPos3D are present.

Have landmarkPos3D and landmarkLabels be recommended if sourcePos3D and detectorPos3D are present.

Additional context

The description of the coordinate system is required when including nirs data in a BIDS dataset: https://bids-specification.readthedocs.io/en/stable/modality-specific-files/near-infrared-spectroscopy.html#coordinate-system-json-_coordsystemjson

@Edouard2laire Edouard2laire added the enhancement New feature or request label Dec 9, 2024
@Edouard2laire Edouard2laire changed the title [Suggestion] Making landmarkPos3D / CoordinateSystem mandatory if Pos3D is present [Suggestion] Making CoordinateSystem mandatory if Pos3D is present Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant