-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happens if both /nirs(i)/data(j)/measurementLists and /nirs(i)/data(j)/measurementList are both present #155
Labels
help wanted
Extra attention is needed
Comments
As an end user, if both fields are present they should contain the same data and you could load either. |
We should surely enforce that only one is present? |
I like the idea of having the validator enforce that only one be present.
BUT
This could be annoying for the user, many of whom will not be skilled enough to fix their snirf file if it had both.
But I could go either way.
Who has strong feelings one way or the other?
…Sent from my iPhone
On Sep 14, 2024, at 4:10 AM, Sam Powell ***@***.***> wrote:
We should surely enforce that only one is present?
—
Reply to this email directly, view it on GitHub<#155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHFCP5F7FNKDR77SKHYQOY3ZWPVQTAVCNFSM6AAAAABOFIKXZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHEYDKMRUGM>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
@dboas if we specify that only one should be present, then compliant software will never write both to a file, and hence the user will never encounter this problem, right? |
Your logic convinces me Sam 😊
From: Sam Powell ***@***.***>
Date: Thursday, September 19, 2024 at 4:18 AM
To: fNIRS/snirf ***@***.***>
Cc: Boas, David ***@***.***>, Mention ***@***.***>
Subject: Re: [fNIRS/snirf] What happens if both /nirs(i)/data(j)/measurementLists and /nirs(i)/data(j)/measurementList are both present (Issue #155)
@dboas<https://github.com/dboas> if we specify that only one should be present, then compliant software will never write both to a file, and hence the user will never encounter this problem, right?
—
Reply to this email directly, view it on GitHub<#155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHFCP5GOCCJS3HMFDKI4FZLZXKCGBAVCNFSM6AAAAABOFIKXZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQGMYDENZRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As asked in the in person meeting
The text was updated successfully, but these errors were encountered: