-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ease Of Life #277
base: next
Are you sure you want to change the base?
Ease Of Life #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would add 0.0.0.0 to the allowed hosts on the production server as well, which I don't think we want.
Does the production server use local.cfg.skel? I would expect that we have previously made a local.cfg that is not tracked in git (https://github.com/f-klubben/stregsystemet/blob/next/.gitignore#L4) that it uses. I don't have access to the server anymore (since AAU closed all port 22 connections) The local.cfg.skel is just a skeleton for new users to have a start for their own local.cfg file. I could be wrong, but I think changing this file in the repo is fine. |
@VirtualSatai previously the PR changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the change being done to local.cfg.skel
the security implications is left to the developer, which I like. I'm probably still leaning towards leaning towards leaving the safest option the default (localhost and 127.0.0.1) and let the unsafer option be "opt-in". With that said, I'm not opposed to this change.
added 0.0.0.0 to allowed hosts, for easier testing on other devices than host device