-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to depend on EyeJs? #23
Comments
Happy to make you a package owner. My original idea was that EyeServer would just expose both: Lines 1 to 2 in 36b3e87
But I'm not strongly opinionated either way. |
Nice move! Joining packages makes total sense, it was just a necessity at the time. but then this repo would need a total upgrade and transform to typescript? |
True; let's leave that as future work 🙂 |
My plan was to make the Eye.js api backwards-compatible (reinstate the callbacks and such) so this repo wouldn't need any code changes and leave it at that for the time being |
A while ago, I splitted off the eye wrapper to modernize it and use it in some other project: https://github.com/mielvds/EyeJs
Back then, the logical follow-up was to create a PR that would remove this logic and import the EyeJs package (not sure that's the best name either), but I never got to it.
I'm opening this issue to not forget about it and also to check whether this is actually desired.
The text was updated successfully, but these errors were encountered: