-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: change jQuery Datepicker to YYMMDD format #44
Comments
@ricardo-lewis |
@64j that's all good and well however it does not help the fact that MTV can only offer sorting via traditional less than < and greater than > etc etc even for date fields. So when an MTV date value is stored in the database right now, it is stored in the format that the above multitv.js file specifies, which is d/m/y. This means that we cannot use sorting and filtering on a date field. In order to achieve that I had to alter the core JS file in the manner I described above. Even if the JS file were to use the System Config, it would still be completely unable to sort and filter unless the config was set to y/m/d. |
The alternative is to update MTV to use true MySQL date sorting functions, or to convert and store the dates as UNIX timestamps. But then the timestamps would need to be converted back to d/m/y again in the Manager. |
@ricardo-lewis |
@64j |
@ricardo-lewis |
@64j |
@64j Are you sure what you doing? This link leads to the same repository where this issue is created |
@mnoskov @ricardo-lewis |
Look, I almost said something but I think what @64j is trying to say is "please submit this as a pull request" I'll admit I was being lazy since I thought it would be way way way way quicker for the actual developer to change 2 lines of code than it would be for me to make a clean fork of the repo, commit my change, and then submit the pull request with all the requirements met. But here we are 7 hours later. |
It is not only to replace 2 lines of code but also to ensure backward compatibility with previous versions. |
Can we please change the datepicker format from MMDDYY to YYMMDD?
This will allow sorting and filtering via >=, <= etc
multiTV/assets/tvs/multitv/js/multitv.js
Line 259 in 866cfd1
multiTV/assets/tvs/multitv/js/multitv.js
Line 988 in 866cfd1
Proposed change:
The text was updated successfully, but these errors were encountered: