Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS should use Ingress-domain #16

Open
ChevronTango opened this issue Feb 20, 2023 · 1 comment
Open

WS should use Ingress-domain #16

ChevronTango opened this issue Feb 20, 2023 · 1 comment

Comments

@ChevronTango
Copy link

The WS config should use Ingress-domain when returning the URL. Currently when a user asks for a websocket transport, the hostname they are connecting to the server with is used to populate the WS url. This can lead to very awkward errors when using loadbalancers or reverse proxies. The WS URL should not rely on anything userspecified, but should instead be entirely derived from server config.

@fredriklindberg
Copy link
Collaborator

The HTTP listener constructs the base url from the incoming request to work out of the box in the majority of the cases.
If the reverse proxy/load balancer injects the correct forwarded headers the constructed url should work. There is currently no way to override the base url.

The API can be restricted to only be available on a specify URL by specifying --api-url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants